[
https://issues.apache.org/jira/browse/HADOOP-19310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17888872#comment-17888872
]
ASF GitHub Bot commented on HADOOP-19310:
-----------------------------------------
pan3793 opened a new pull request, #7114:
URL: https://github.com/apache/hadoop/pull/7114
<!--
Thanks for sending a pull request!
1. If this is your first time, please read our contributor guidelines:
https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
2. Make sure your PR title starts with JIRA issue id, e.g.,
'HADOOP-17799. Your PR title ...'.
-->
HADOOP-19310. Add JPMS options required by Java 17+
### Description of PR
This PR adds JPMS args to both maven surefire plugins and
`hadoop-functions.sh`, to fix issues like the below that happen with JDK 17+,
for all of the modules in the Hadoop project.
```
module java.base does not "opens java.lang" to unnamed module @7ee7980d
```
This is the next step of HADOOP-19219, which fixes the JPMS issues for
`hadoop-common`.
### How was this patch tested?
Test environment: x86 Ubuntu 22.04, Zulu JDK 17.0.8, Maven 3.9.8
Run all tests except for
1. native tests -further native libraries setup that I'm not familiar with.
2. an
[exclude-tests.txt](https://github.com/pan3793/hadoop/blob/jpms-2/dev-support/java-17/exclude-tests.txt)
list that failed on JDK 17 due to other reasons that need to be addressed
independently.
3. `hadoop-yarn-server-timelineservice-hbase-tests` -surefire runs in
non-fork mode thus JPMS args do not take effect.
```
mvn clean install --fail-at-end \
-Dsurefire.excludesFile=$PWD/dev-support/java-17/exclude-tests.txt
```
The whole UT takes around 18-24 hours to finish, for developers who want to
contribute to Java 17 support, please focus on the
[exclude-tests.txt](https://github.com/pan3793/hadoop/blob/jpms-2/dev-support/java-17/exclude-tests.txt),
and I will update the list timely.
### For code changes:
- [x] Does the title or this PR starts with the corresponding JIRA issue id
(e.g. 'HADOOP-17799. Your PR title ...')?
- [ ] Object storage: have the integration tests been executed and the
endpoint declared according to the connector-specific documentation?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`,
`NOTICE-binary` files?
> [JDK17] Add JPMS options required by Java 17+
> ---------------------------------------------
>
> Key: HADOOP-19310
> URL: https://issues.apache.org/jira/browse/HADOOP-19310
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Cheng Pan
> Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
