slfan1989 commented on code in PR #7085:
URL: https://github.com/apache/hadoop/pull/7085#discussion_r1797690932


##########
hadoop-project/pom.xml:
##########
@@ -2737,6 +2737,46 @@
         </dependencies>
       </dependencyManagement>
     </profile>
+    <profile>
+      <id>jdk17</id>
+      <activation>
+        <jdk>[17,)</jdk>
+      </activation>
+      <properties>
+        <maven.compiler.release>17</maven.compiler.release>
+        <argLine>
+          --add-opens java.base/jdk.internal.ref=ALL-UNNAMED

Review Comment:
   ```
      <profile>
         <id>java9</id>
         <activation>
           <jdk>[9,)</jdk>
         </activation>
         <properties>
           <maven.compiler.release>${javac.version}</maven.compiler.release>
           <argLine>
             ${maven-surefire-plugin.argLine}
           </argLine>
         </properties>
       </profile>
   ```
   
   The Javadoc configuration can be removed, as it currently doesn’t cause any 
extra errors since Pan has submitted a PR to fix the Javadoc content.
   
   cc: @pan3793 @adoroszlai 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to