[
https://issues.apache.org/jira/browse/HADOOP-19278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17893818#comment-17893818
]
ASF GitHub Bot commented on HADOOP-19278:
-----------------------------------------
shameersss1 commented on code in PR #7052:
URL: https://github.com/apache/hadoop/pull/7052#discussion_r1820775305
##########
hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/directory_markers.md:
##########
@@ -247,8 +250,6 @@ directory markers when creating files under paths. This
removes all scalability
problems caused by deleting these markers -however, it is achieved at the
expense
of backwards compatibility.
-## <a name="marker-retention"></a> Controlling marker retention with
`fs.s3a.directory.marker.retention`
-
There is now an option `fs.s3a.directory.marker.retention` which controls how
Review Comment:
Should we remove this as well ?
##########
hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/directory_markers.md:
##########
@@ -306,7 +290,6 @@ line of bucket policies via the `-marker` option
Review Comment:
Should we edit this table as well ? delete and authoritative are not valid
anymore
##########
hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/index.md:
##########
@@ -77,7 +77,7 @@ and compatible implementations.
* Directly reads and writes S3 objects.
* Compatible with standard S3 clients.
-* Compatible with files created by the older `s3n://` client and Amazon EMR's
`s3://` client.
+* Compatible with files created by Amazon EMR's `s3://` client.
Review Comment:
Better to call it out as Amazon EMR's `s3://` client (EMRFS).
> S3A: remove option to delete directory markers
> ----------------------------------------------
>
> Key: HADOOP-19278
> URL: https://issues.apache.org/jira/browse/HADOOP-19278
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs/s3
> Affects Versions: 3.4.1
> Reporter: Steve Loughran
> Priority: Major
> Labels: pull-request-available
>
> We've supported directory marker retention since HADOOP-13230 went in.
> and switch to making it the default in HADOOP-18752
> nobody has ever complained about this.
> proposed: cut directory marker deletion entirely.
> this will
> * simplify our code
> * cut down on test options
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
