brumi1024 commented on code in PR #7144:
URL: https://github.com/apache/hadoop/pull/7144#discussion_r1850611197
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/SecretManager.java:
##########
@@ -111,12 +117,26 @@ public void checkAvailableForRead() throws
StandbyException {
/**
* The name of the hashing algorithm.
*/
+ private static final String HMAC_ALGORITHM =
"hadoop.security.hmac-algorithm";
private static final String DEFAULT_HMAC_ALGORITHM = "HmacSHA1";
+ private static final String SELECTED_ALGORITHM;
/**
* The length of the random keys to use.
*/
- private static final int KEY_LENGTH = 64;
+ private static final String HMAC_LENGTH = "hadoop.security.hmac-length";
+ private static final int DEFAULT_HMAC_LENGTH = 64;
+ private static final int SELECTED_LENGTH;
+
+ static {
+ Configuration conf = new Configuration();
+ String algorithm = conf.get(HMAC_ALGORITHM, DEFAULT_HMAC_ALGORITHM);
Review Comment:
I might be missing something, is this config introduced in a different PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
