[
https://issues.apache.org/jira/browse/HADOOP-19226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17900945#comment-17900945
]
ASF GitHub Bot commented on HADOOP-19226:
-----------------------------------------
anujmodi2021 commented on code in PR #6944:
URL: https://github.com/apache/hadoop/pull/6944#discussion_r1856856277
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystemStore.java:
##########
@@ -405,7 +405,7 @@ private synchronized boolean
getNamespaceEnabledInformationFromServer(
}
try {
LOG.debug("Get root ACL status");
- getClient().getAclStatus(AbfsHttpConstants.ROOT_PATH, tracingContext);
+ getClient(AbfsServiceType.DFS).getAclStatus(AbfsHttpConstants.ROOT_PATH,
tracingContext);
Review Comment:
So the method `getClient(AbfsServiceType.DFS)` will internally call
`getClientHandler().getDfsClient()`.
The URi to interact with will be encapsulated into the client in this case
DFS Client so the URL will always be DFS endpoit URL.
Refer to `AbfsClientHandler` constructor. There we explicitly check and make
sure AbfsDfsClient is initialized with DFS Endpoint URL.
That's why I think this check here will be redundant.
> ABFS: [FnsOverBlob] Implementing Azure Rest APIs on Blob Endpoint for
> AbfsBlobClient
> ------------------------------------------------------------------------------------
>
> Key: HADOOP-19226
> URL: https://issues.apache.org/jira/browse/HADOOP-19226
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/azure
> Affects Versions: 3.4.0
> Reporter: Anuj Modi
> Assignee: Anuj Modi
> Priority: Major
> Labels: pull-request-available
>
> This is second task in series of tasks for implementing Blob Endpoint support
> for FNS accounts.
> This patch will have changes to implement all the APIs over Blob Endpoint as
> a part of implementing AbfsBlobClient.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
