huangzhaobo99 commented on code in PR #7242:
URL: https://github.com/apache/hadoop/pull/7242#discussion_r1897112095
##########
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancerService.java:
##########
@@ -210,4 +216,49 @@ public void testBalancerServiceOnError() throws Exception {
}
}
}
+
+ @Test(timeout = 60000)
+ public void testBalancerServiceMetrics() throws Exception {
+ Configuration conf = new HdfsConfiguration();
+ conf.setTimeDuration(DFSConfigKeys.DFS_BALANCER_SERVICE_INTERVAL_KEY, 5,
TimeUnit.SECONDS);
+ TestBalancer.initConf(conf);
+ try {
Review Comment:
@tomscut Thanks for the review. The UT method of this class requires some
additional operations on cluster, such as the `addOneDataNode()` method, which
does not take cluster as a parameter.
If to change the usage, I can create a new JIRA to complete the task.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
