anmolanmol1234 commented on code in PR #7272:
URL: https://github.com/apache/hadoop/pull/7272#discussion_r1917800232
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystem.java:
##########
@@ -234,6 +236,27 @@ public void initialize(URI uri, Configuration
configuration)
throw new
InvalidConfigurationValueException(FS_AZURE_ACCOUNT_IS_HNS_ENABLED, ex);
}
+ /**
+ * Validates if the FixedSASTokenProvider is configured for non-HNS
accounts.
+ * If the namespace is not enabled and the FixedSASTokenProvider is not
configured,
+ * the filesystem is closed and an InvalidConfigurationValueException is
thrown.
+ *
+ * @throws InvalidConfigurationValueException if the namespace is not
enabled and the FixedSASTokenProvider is not configured.
+ */
+ try {
+ if (!getIsNamespaceEnabled(new TracingContext(initFSTracingContext))
Review Comment:
taken
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystem.java:
##########
@@ -234,6 +236,27 @@ public void initialize(URI uri, Configuration
configuration)
throw new
InvalidConfigurationValueException(FS_AZURE_ACCOUNT_IS_HNS_ENABLED, ex);
}
+ /**
+ * Validates if the FixedSASTokenProvider is configured for non-HNS
accounts.
+ * If the namespace is not enabled and the FixedSASTokenProvider is not
configured,
+ * the filesystem is closed and an InvalidConfigurationValueException is
thrown.
+ *
+ * @throws InvalidConfigurationValueException if the namespace is not
enabled and the FixedSASTokenProvider is not configured.
+ */
+ try {
+ if (!getIsNamespaceEnabled(new TracingContext(initFSTracingContext))
+ && !abfsConfiguration.isFixedSASTokenProviderConfigured()) {
+ close();
Review Comment:
taken
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
