[
https://issues.apache.org/jira/browse/HADOOP-8230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269920#comment-13269920
]
Suresh Srinivas commented on HADOOP-8230:
-----------------------------------------
bq. Do you think there many users who'd want to do this Suresh?
There are several clusters that I support that do not use sync, that currently
runs with append turned off.
bq. I'd think the number few and if there any still conscious this option even
exists, they are probably suffering from the FUD that sync is buggy/broke. We
should help them get over their misconception?
I agree that the code that is being enabled has been stable for some time,
which is the main reason why it was ported to 0.20.205. However I would like to
retain the existing behavior and not enable a change unnecessarily on these
clusters. This avoids having to worry about or spend time looking at any
bugs/changed behavior that might crop up.
For these kinds of changes (see several token related changes that happened in
1.x), I have always advocated adding a flag so existing deployments can stay
unaffected. I am asking the same here. It is more important given this patch
removed an option that existed to turn off new code.
bq. if you feel strongly that we should have a config option that let's people
keep the previous/broken sync behavior go for it
The need for an option is a comment on the patch committed in this jira. Sorry
I could not comment quickly enough, as this patch was committed with a short
turn around time. I think it should be addressed as a subsequent patch for this
jira and not a separate optional item. Alternatively we could revert this
change and rework it to add a flag.
> Enable sync by default and disable append
> -----------------------------------------
>
> Key: HADOOP-8230
> URL: https://issues.apache.org/jira/browse/HADOOP-8230
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 1.0.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Fix For: 1.1.0
>
> Attachments: hadoop-8230.txt
>
>
> Per HDFS-3120 for 1.x let's:
> - Always enable the sync path, which is currently only enabled if
> dfs.support.append is set
> - Remove the dfs.support.append configuration option. We'll keep the code
> paths though in case we ever fix append on branch-1, in which case we can add
> the config option back
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
