cnauroth commented on code in PR #7339:
URL: https://github.com/apache/hadoop/pull/7339#discussion_r1936059923
##########
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/cli/CLITestHelper.java:
##########
@@ -155,31 +160,27 @@ private void displayResults() {
// Display the details only if there is a failure
if (!testResult) {
LOG.info("-------------------------------------------");
- LOG.info(" Test ID: [" + (i + 1) + "]");
- LOG.info(" Test Description: [" + td.getTestDesc() + "]");
+ LOG.info(" Test ID: [ {} ]", (i + 1));
Review Comment:
Unrelated style change?
##########
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/crypto/TestOpensslCipher.java:
##########
@@ -24,42 +24,46 @@
import javax.crypto.ShortBufferException;
import org.apache.hadoop.test.GenericTestUtils;
-import org.junit.Assume;
-import org.junit.Assert;
-import org.junit.Test;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.Timeout;
+
+import static org.junit.jupiter.api.Assertions.*;
+import static org.junit.jupiter.api.Assumptions.assumeTrue;
public class TestOpensslCipher {
private static final byte[] key = {0x01, 0x02, 0x03, 0x04, 0x05, 0x06,
0x07, 0x08, 0x09, 0x10, 0x11, 0x12, 0x13, 0x14, 0x15, 0x16};
private static final byte[] iv = {0x01, 0x02, 0x03, 0x04, 0x05, 0x06,
0x07, 0x08, 0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07, 0x08};
- @Test(timeout=120000)
+ @Test
+ @Timeout(value = 120)
public void testGetInstance() throws Exception {
- Assume.assumeTrue(OpensslCipher.getLoadingFailureReason() == null);
+ assumeTrue(OpensslCipher.getLoadingFailureReason() == null);
OpensslCipher cipher = OpensslCipher.getInstance("AES/CTR/NoPadding");
- Assert.assertTrue(cipher != null);
+ assertNotNull(cipher);
Review Comment:
Unrelated assert style change?
##########
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/cli/CLITestHelper.java:
##########
@@ -113,8 +119,7 @@ public void setUp() throws Exception {
readTestConfigFile();
conf = new Configuration();
- conf.setBoolean(CommonConfigurationKeys.HADOOP_SECURITY_AUTHORIZATION,
- true);
+ conf.setBoolean(CommonConfigurationKeys.HADOOP_SECURITY_AUTHORIZATION,
true);
Review Comment:
Unrelated formatting change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
