slfan1989 commented on PR #7347: URL: https://github.com/apache/hadoop/pull/7347#issuecomment-2635526163
> `TestViewFSOverloadSchemeCentralMountTableConfig` is a subclass of `TestViewFileSystemOverloadSchemeLocalFileSystem`. In your patch, the base class has been converted to JUnit 5 with the Jupiter annotations. The subclass though is still using `org.junit.Before`, so maybe its test setup is not getting triggered. Do we need to convert that one to `org.junit.jupiter.api.BeforeEach`? @cnauroth Thank you very much for reviewing the code! This is an issue we are already aware of—there are some abstract test classes in hadoop-common that are used by multiple modules, such as hadoop-azure, hadoop-aws, hadoop-distcp, etc. Our plan is to first upgrade the parts without dependencies, and then submit a unified PR to handle the dependent parts. To ensure this PR passes the build, I plan to roll back the changes to TestViewFSOverloadSchemeCentralMountTableConfig. Additionally, I will fix the checkstyle and blank issues. We hope that the feedback from Yetus will be positive, and the build will pass successfully. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
