[
https://issues.apache.org/jira/browse/HADOOP-8292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270998#comment-13270998
]
Hadoop QA commented on HADOOP-8292:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12526085/HADOOP-8292.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 1 new or modified test
files.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these unit tests in
hadoop-common-project/hadoop-common:
org.apache.hadoop.fs.viewfs.TestViewFsTrash
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/963//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/963//console
This message is automatically generated.
> TableMapping does not refresh when topology is updated
> ------------------------------------------------------
>
> Key: HADOOP-8292
> URL: https://issues.apache.org/jira/browse/HADOOP-8292
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 2.0.0
> Reporter: Philip Zeyliger
> Assignee: Alejandro Abdelnur
> Attachments: HADOOP-8292.patch
>
>
> HADOOP-7030 introduced TableMapping, an implementation of DNSToSwitchMapping
> which uses a file to map from IPs/hosts to their racks. It's intended to
> replace ScriptBasedMapping for cases where the latter was just a complicated
> way of looking up the rack in a file.
> Though there was discussion of it on the JIRA, the TableMapping
> implementation is not 'refreshable'. i.e., if you want to add a host to your
> cluster, and that host wasn't in the topology file to begin with, it will
> never be added.
> TableMapping should refresh, either based on a command that can be executed,
> or, perhaps, if the file on disk changes.
> I'll also point out that TableMapping extends CachedDNSToSwitchMapping, but,
> since it does no refreshing, I don't see what the caching gets you: I think
> the cache ends up being a second copy of the underlying map, always.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
