hfutatzhanghb commented on PR #6927:
URL: https://github.com/apache/hadoop/pull/6927#issuecomment-2644501105
yes, Sir. we now allocate 3 hashmaps.
---- Replied Message ----
| From | Chris ***@***.***> |
| Date | 02/08/2025 12:39 |
| To | ***@***.***> |
| Cc | ***@***.***>***@***.***> |
| Subject | Re: [apache/hadoop] HADOOP-19377. Avoid initialize useless
HashMap in protocolImplMapArray. (PR #6927) |
@cnauroth commented on this pull request.
@hfutatzhanghb , oh wait! So I think the material change is on line 1093.
Before:
for (int i=0; i <= RpcKind.MAX_INDEX; ++i) {
After:
for (int i = 0; i < RpcKind.MAX_SIZE; ++i) {
This is changing from <= to <, which I missed in my first pass of the
review, so now allocating 3 HashMap instead of 4. Is that right?
If my understanding of the patch is correct now, then I think this makes
sense.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
