[
https://issues.apache.org/jira/browse/HADOOP-19469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17930933#comment-17930933
]
ASF GitHub Bot commented on HADOOP-19469:
-----------------------------------------
Hexiaoqiao commented on PR #7426:
URL: https://github.com/apache/hadoop/pull/7426#issuecomment-2686742453
Thanks @xyu for your detailed comments.
> what do you think about hadoop.zk.curator-connection-timeout-ms with a
default value of 10000 to match the current hadoop.zk.timeout-ms default config.
+1.
> I was a bit hesitant to do this at first because I find it a little
annoying that we have to expose a tuning for Curator into Hadoop configs.
Strong +1 from my side. Now the config items is so many to confuse end user.
I have no idea to improve that currently. Back to this PR, I think expose
ZK/Curator config is proper based on the current status because we could not
manage ZK/Curator logic in Hadoop community, so leave the choice to end user
maybe one reasonable tradeoff.
About the default value, I prefer change the default Hadoop ZK timeout from
10s to 15s and give `hadoop.zk.curator-connection-timeout-ms` with 10000ms by
default.
Thanks again.
> Set Curator Connection Timeout
> ------------------------------
>
> Key: HADOOP-19469
> URL: https://issues.apache.org/jira/browse/HADOOP-19469
> Project: Hadoop Common
> Issue Type: Bug
> Components: hadoop-common
> Affects Versions: 3.3.6, 3.5.0
> Reporter: Xiao Yu
> Priority: Minor
> Labels: pull-request-available
>
> Curator 5.2.0 has a default "connection timeout" of 15s:
> [https://github.com/apache/curator/blob/apache-curator-5.2.0/curator-framework/src/main/java/org/apache/curator/framework/CuratorFrameworkFactory.java#L63]
> And it will throw a warning if the Zookeeper session timeout is less than the
> Curator connection timeout:
> [https://github.com/apache/curator/blob/apache-curator-5.2.0/curator-client/src/main/java/org/apache/curator/CuratorZookeeperClient.java#L117-L120]
> The Hadoop default for ZK timeout is set to 10s:
> [https://github.com/apache/hadoop/blob/0dd9bf8/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeys.java#L414-L416]
> Which means without setting the "connection timeout" a default installation
> will keep warning about the connection timeout for Curator being lower than
> the requested session timeout. This sets both timeout values to override the
> Curator default.
> Another option is to change the default Hadoop ZK timeout from 10s to 15s.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
