[
https://issues.apache.org/jira/browse/HADOOP-19478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932294#comment-17932294
]
ASF GitHub Bot commented on HADOOP-19478:
-----------------------------------------
steveloughran opened a new pull request, #7463:
URL: https://github.com/apache/hadoop/pull/7463
New service under S3AStoreImpl: StoreConfigurationService
This is just the draft design; it is intended to be a place to move most of
our configuration options:
flags, durations etc, ideally lifting some of the work from
org.apache.hadoop.fs.azurebfs.contracts.annotations.ConfigurationValidationAnnotations,
* putting it into common
* adding duration and size attributes
* move reflection code from AbfsConfiguration#AbfsConfiguration into there
too, and apply
Lifted from #7362, where it will be cut. Because of that lift: doesn't yet
compile
### How was this patch tested?
### For code changes:
- [ ] Does the title or this PR starts with the corresponding JIRA issue id
(e.g. 'HADOOP-17799. Your PR title ...')?
- [ ] Object storage: have the integration tests been executed and the
endpoint declared according to the connector-specific documentation?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`,
`NOTICE-binary` files?
> S3A: pull out new configuration load/probes under S3AStore
> ----------------------------------------------------------
>
> Key: HADOOP-19478
> URL: https://issues.apache.org/jira/browse/HADOOP-19478
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 3.4.1
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Major
>
> S3AFS i's too full of switches; it is why initialize() is so big, and there
> are lots and lots of fields to record the values.
> Many of these need to go down into S3AStoreImpl, but replicating the same
> design just pushes the mess down.
> Proposed: a child service StoreConfigurationService, which reads in the
> config during serviceInit(), and set the state in there, from where it can be
> probed.
> I am initially doing this purely for new configuration flags for the
> conditional write feature
> * moving other flags in there would be separate work
> * new boolean config options should go in here
> * we also need to think about integers, units of scale and durations.
> Ideally, we should the annotations and reflection code from ABFS and
> org.apache.hadoop.fs.azurebfs.contracts.annotations.ConfigurationValidationAnnotations,
> * copy it into common
> * adding duration and size attributes
> * move reflection code from AbfsConfiguration#AbfsConfiguration into there
> too,
> * use in s3a
> * migrate abfs to the moved code
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
