slfan1989 commented on code in PR #7453:
URL: https://github.com/apache/hadoop/pull/7453#discussion_r1980526233


##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests/src/test/java/org/apache/hadoop/yarn/server/timelineservice/reader/AbstractTimelineReaderHBaseTestBase.java:
##########
@@ -109,19 +106,25 @@ protected void addFilters(Configuration conf) {
   }
 
   protected Client createClient() {
-    ClientConfig cfg = new DefaultClientConfig();
-    cfg.getClasses().add(YarnJacksonJaxbJsonProvider.class);
-    return new Client(
-        new URLConnectionClientHandler(new DummyURLConnectionFactory()), cfg);
+    final ClientConfig cc = new ClientConfig();
+    cc.connectorProvider(getHttpURLConnectionFactory());
+    return ClientBuilder.newClient(cc)
+        .register(TimelineEntityReader.class)

Review Comment:
   @cnauroth Thank you for your message. We need to ensure the compatibility of 
the interfaces. For the YARN REST API, most interfaces have no compatibility 
issues. Even after upgrading to Jersey 2, the changes to the server's 
WebService are minimal, usually just adding readers and writers. While there 
are still a few interfaces that need re-validation, I have a general 
understanding of the areas that need to be checked. We can work together to 
complete this task, which must be done before the release of 3.5.0.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to