[
https://issues.apache.org/jira/browse/HADOOP-19399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17933341#comment-17933341
]
ASF GitHub Bot commented on HADOOP-19399:
-----------------------------------------
ahmarsuhail commented on code in PR #7443:
URL: https://github.com/apache/hadoop/pull/7443#discussion_r1985149106
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/ClientManagerImpl.java:
##########
@@ -142,12 +148,18 @@ private CallableRaisingIOE<S3Client> createS3Client() {
* @return a callable which will create the client.
*/
private CallableRaisingIOE<S3AsyncClient> createAsyncClient() {
- return trackDurationOfOperation(
- durationTrackerFactory,
- STORE_CLIENT_CREATION.getSymbol(),
- () -> clientFactory.createS3AsyncClient(getUri(),
clientCreationParameters));
+ return trackDurationOfOperation(durationTrackerFactory,
STORE_CLIENT_CREATION.getSymbol(),
Review Comment:
this should actually go into the client factory, not here. moving this over
> S3A: Add support for CRT client
> -------------------------------
>
> Key: HADOOP-19399
> URL: https://issues.apache.org/jira/browse/HADOOP-19399
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 3.4.1
> Reporter: Ahmar Suhail
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.2
>
>
> * Allow ClientManager to initialise a CRT client
> * Should be optional, java async client to still be supported as default
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
