shameersss1 commented on code in PR #7443:
URL: https://github.com/apache/hadoop/pull/7443#discussion_r1986717723
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/DefaultS3ClientFactory.java:
##########
@@ -175,6 +163,39 @@ public S3AsyncClient createS3AsyncClient(
return s3AsyncClientBuilder.build();
}
+ private S3AsyncClient createS3CrtAsyncClient(URI uri,
S3ClientCreationParameters parameters)
+ throws IOException {
+ Configuration conf = getConf();
+ String bucket = uri.getHost();
+
+ S3CrtAsyncClientBuilder s3CrtAsyncClientBuilder =
S3CrtAsyncClient.builder();
+
+ AWSRegionEndpointInformation regionEndpointInformation =
+ AWSRegionEndpointResolver.getEndpointRegionResolution(parameters,
conf);
+
+ if (regionEndpointInformation.getRegion() != null) {
+ s3CrtAsyncClientBuilder.region(regionEndpointInformation.getRegion());
+ }
+
+ if (regionEndpointInformation.getEndpoint() != null) {
+
s3CrtAsyncClientBuilder.endpointOverride(regionEndpointInformation.getEndpoint());
Review Comment:
Is setting both endpoint and region expected ? Won't the client throw
exception in that case ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
