pan3793 commented on code in PR #7499:
URL: https://github.com/apache/hadoop/pull/7499#discussion_r1991825517
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-csi/pom.xml:
##########
@@ -27,6 +27,8 @@
<properties>
<grpc.version>1.69.0</grpc.version>
+ <!-- Last version that works with Centos 7 -->
+ <grpc.plugin.version>1.65.0</grpc.plugin.version>
Review Comment:
> There are no code changes in the compiler between those versions
it's fine for these specific version pair, but may not be good for future
upgrading
> committing generated code to git is troublesome, I would very much like to
avoid that.
I tend to agree with you in most cases, but I think for this case, it's a
most safe and relatively cheap way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
