steveloughran commented on code in PR #7503:
URL: https://github.com/apache/hadoop/pull/7503#discussion_r1995546215
##########
hadoop-tools/hadoop-sls/src/test/java/org/apache/hadoop/yarn/sls/TestSLSDagAMSimulator.java:
##########
@@ -62,6 +66,8 @@ public static Collection<Object[]> data() {
@Before
public void setup() {
+ //JavaScript engine has been removed from Java in Java 15.
+ assumeNotNull(new ScriptEngineManager().getEngineByName("JavaScript"));
Review Comment:
this is a common assert. why not pull it out into some shared utility class
+ add a text message as to why it was skipped, just for those test reports
##########
hadoop-tools/hadoop-sls/src/test/java/org/apache/hadoop/yarn/sls/TestSLSDagAMSimulator.java:
##########
@@ -28,9 +28,13 @@
import org.junit.runners.Parameterized;
import org.junit.runners.Parameterized.Parameters;
+import static org.junit.Assume.assumeNotNull;
Review Comment:
if you don't factor out the common assert, can you put the static import at
the bottom of all other imports. thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
