[ 
https://issues.apache.org/jira/browse/HADOOP-18652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17938347#comment-17938347
 ] 

ASF GitHub Bot commented on HADOOP-18652:
-----------------------------------------

FX196 opened a new pull request, #7536:
URL: https://github.com/apache/hadoop/pull/7536

   <!--
     Thanks for sending a pull request!
       1. If this is your first time, please read our contributor guidelines: 
https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
       2. Make sure your PR title starts with JIRA issue id, e.g., 
'HADOOP-17799. Your PR title ...'.
   -->
   
   ### Description of PR
   The existing implementation of `Path.suffix` drops the scheme and authority 
of the path when it's a root path. For example, `new 
Path("s3://foo").suffix("/bar")` is expected to return a path for 
`s3://foo/bar`, but the current implementation returns `/bar`.
   
   This PR fixes the implementation such that `.suffix` works with root bucket 
paths.
   
   ### How was this patch tested?
   Added a new test
   
   
   ### For code changes:
   
   - [ ] Does the title or this PR starts with the corresponding JIRA issue id 
(e.g. 'HADOOP-17799. Your PR title ...')?
   - [ ] Object storage: have the integration tests been executed and the 
endpoint declared according to the connector-specific documentation?
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, 
`NOTICE-binary` files?
   
   




> Path.suffix raises NullPointerException
> ---------------------------------------
>
>                 Key: HADOOP-18652
>                 URL: https://issues.apache.org/jira/browse/HADOOP-18652
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: hdfs-client
>    Affects Versions: 3.4.0, 3.3.6
>            Reporter: Patrick Grandjean
>            Assignee: Patrick Grandjean
>            Priority: Minor
>             Fix For: 3.4.0, 3.3.6
>
>
> Calling the Path.suffix method on root raises a NullPointerException. Tested 
> with hadoop-client-api 3.3.2
> Scenario:
> {code:java}
> import org.apache.hadoop.fs.*
> Path root = new Path("/")
> root.getParent == null  // true
> root.suffix("bar")  // NPE is raised
> {code}
> Stack:
> {code:none}
> 23/03/03 15:13:18 ERROR Uncaught throwable from user code: 
> java.lang.NullPointerException
>     at org.apache.hadoop.fs.Path.<init>(Path.java:104)
>     at org.apache.hadoop.fs.Path.<init>(Path.java:93)
>     at org.apache.hadoop.fs.Path.suffix(Path.java:361)
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to