[
https://issues.apache.org/jira/browse/HADOOP-19474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17938602#comment-17938602
]
ASF GitHub Bot commented on HADOOP-19474:
-----------------------------------------
anmolanmol1234 commented on code in PR #7421:
URL: https://github.com/apache/hadoop/pull/7421#discussion_r2014066457
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsBlobClient.java:
##########
@@ -404,13 +403,8 @@ public ListResponseData listPath(final String
relativePath, final boolean recurs
BlobListResultSchema listResultSchema =
getListResultSchemaFromPathStatus(relativePath, pathStatus);
LOG.debug("ListBlob attempted on a file path. Returning file status.");
List<FileStatus> fileStatusList = new ArrayList<>();
- Map<Path, Integer> renamePendingJsonPaths = new HashMap<>();
for (BlobListResultEntrySchema entry : listResultSchema.paths()) {
- if (isRenamePendingJsonPathEntry(entry)) {
- renamePendingJsonPaths.put(entry.path(),
entry.contentLength().intValue());
- } else {
- fileStatusList.add(getVersionedFileStatusFromEntry(entry, uri));
- }
+ fileStatusList.add(getVersionedFileStatusFromEntry(entry, uri));
Review Comment:
didn't understand why this change to remove renamePending paths was removed
> ABFS: [FnsOverBlob] Listing Optimizations to avoid multiple iteration over
> list response.
> -----------------------------------------------------------------------------------------
>
> Key: HADOOP-19474
> URL: https://issues.apache.org/jira/browse/HADOOP-19474
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/azure
> Affects Versions: 3.5.0, 3.4.1
> Reporter: Anuj Modi
> Assignee: Anuj Modi
> Priority: Major
> Labels: pull-request-available
>
> On blob endpoint, there are a couple of handling that is needed to be done on
> client side.
> This involves:
> # Parsing of xml response and converting them to VersionedFileStatus list
> # Removing duplicate entries for non-empty explicit directories coming due
> to presence of the marker files
> # Trigerring Rename recovery on the previously failed rename indicated by
> the presence of pending json file.
> Currently all three are done in a separate iteration over whole list. This is
> to pbring all those things to a common place so that single iteration over
> list reposne can handle all three.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
