[
https://issues.apache.org/jira/browse/HADOOP-8367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13276902#comment-13276902
]
Suresh Srinivas commented on HADOOP-8367:
-----------------------------------------
Minor comments:
# ProtobufRpcEngine.java
#* Typo differnt
#* The newly added comment is not very clear. Can you please add more
information about what you mean by metaProtocols. Also the sentense does not
read right. It might make sense to capture the same comments from
hadoop_rpc.proto in here.
# hadoop_rpc.proto some lines are going beyond 80 characters. Also the last
sentence in the newly added comment does not read right.
> Better document the declaringClassProtocolName in the rpc headers better
> ------------------------------------------------------------------------
>
> Key: HADOOP-8367
> URL: https://issues.apache.org/jira/browse/HADOOP-8367
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 2.0.0
> Reporter: Sanjay Radia
> Assignee: Sanjay Radia
> Attachments: hadoop-8367-1.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
