anujmodi2021 commented on code in PR #7523:
URL: https://github.com/apache/hadoop/pull/7523#discussion_r2024449821
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystem.java:
##########
@@ -250,6 +251,7 @@ public void initialize(URI uri, Configuration configuration)
try {
Review Comment:
Need to update the comment above.
##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemDelegationSAS.java:
##########
@@ -217,6 +220,7 @@ public void testReadAndWrite() throws Exception {
@Test
public void checkExceptionForRenameOverwrites() throws Exception {
+ assumeHnsEnabled();
Review Comment:
Why??
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsErrors.java:
##########
@@ -62,7 +62,7 @@ public final class AbfsErrors {
/**
* Exception message on filesystem init if token-provider-auth-type configs
are provided
*/
- public static final String UNAUTHORIZED_SAS = "Incorrect SAS token provider
configured for non-hierarchical namespace account.";
+ public static final String UNAUTHORIZED_SAS = "Incorrect SAS token provider
configured for non-hierarchical namespace account with DFS service type.";
Review Comment:
Split line length
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsBlobClient.java:
##########
@@ -364,7 +364,7 @@ public AbfsRestOperation listPath(final String
relativePath, final boolean recur
abfsUriQueryBuilder.addQuery(QUERY_PARAM_DELIMITER, FORWARD_SLASH);
}
abfsUriQueryBuilder.addQuery(QUERY_PARAM_MAX_RESULTS,
String.valueOf(listMaxResults));
- appendSASTokenToQuery(relativePath,
SASTokenProvider.FIXED_SAS_STORE_OPERATION, abfsUriQueryBuilder);
+ appendSASTokenToQuery(relativePath, SASTokenProvider.LIST_OPERATION_BLOB,
abfsUriQueryBuilder);
Review Comment:
Why do we need different SASTokenProvider Operation for listing on Blob? Are
permissions different than that of DFS?
##########
hadoop-tools/hadoop-azure/src/site/markdown/abfs.md:
##########
@@ -663,13 +663,13 @@ To know more about how SAS Authentication works refer to
[Grant limited access to Azure Storage resources using shared access
signatures
(SAS)](https://learn.microsoft.com/en-us/azure/storage/common/storage-sas-overview)
There are three types of SAS supported by Azure Storage:
-- [User Delegation
SAS](https://learn.microsoft.com/en-us/rest/api/storageservices/create-user-delegation-sas):
Recommended for use with ABFS Driver with HNS Enabled ADLS Gen2 accounts. It
is Identity based SAS that works at blob/directory level)
+- [User Delegation
SAS](https://learn.microsoft.com/en-us/rest/api/storageservices/create-user-delegation-sas):
Recommended for use with ABFS Driver with HNS Enabled ADLS Gen2 accounts or
HNS-Disabled Blob Storage accounts. It is Identity based SAS that works at
blob/directory level)
Review Comment:
Yes recommended only for HNS-DFS.
Supported on HNS-DFS and FNS-BLOB
Not supported on FNS-DFS
This should be clearly conveyed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
