pan3793 commented on PR #7599:
URL: https://github.com/apache/hadoop/pull/7599#issuecomment-2803816795

   @yangjiandan compatibility concerns are not the interface itself, it's about 
the reference.
   
   as I mentioned in the PR description, 
`org.apache.hadoop.yarn.server.resourcemanager.reservation.PlanFollower` is a 
public API and references `org.apache.hadoop.yarn.util.Clock`, your change 
would break the third-party implementation that compiled with old Hadoop 
version.
   
   > ... it still makes sense to have the clock-related classes in 
hadoop-common, as they are potentially useful across multiple Hadoop 
subprojects.
   
   when required, you can introduce new interfaces in hadoop-common or just use 
`java.time.Clock` provided by JDK, but don't change the existing usage.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to