[
https://issues.apache.org/jira/browse/HADOOP-19406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17945031#comment-17945031
]
ASF GitHub Bot commented on HADOOP-19406:
-----------------------------------------
bhattmanish98 commented on code in PR #7523:
URL: https://github.com/apache/hadoop/pull/7523#discussion_r2046592824
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsBlobClient.java:
##########
@@ -1056,7 +1058,7 @@ public AbfsRestOperation flush(byte[] buffer,
final AbfsUriQueryBuilder abfsUriQueryBuilder =
createDefaultUriQueryBuilder();
abfsUriQueryBuilder.addQuery(QUERY_PARAM_COMP, BLOCKLIST);
abfsUriQueryBuilder.addQuery(QUERY_PARAM_CLOSE, String.valueOf(isClose));
- String sasTokenForReuse = appendSASTokenToQuery(path,
SASTokenProvider.FIXED_SAS_STORE_OPERATION,
+ String sasTokenForReuse = appendSASTokenToQuery(path,
SASTokenProvider.WRITE_OPERATION,
Review Comment:
Is using WRITE_OPERATION for the flush call a good idea? Should we create
another operation type for this?
> ABFS: [FNS Over Blob] Support User Delegation SAS for FNS Blob
> --------------------------------------------------------------
>
> Key: HADOOP-19406
> URL: https://issues.apache.org/jira/browse/HADOOP-19406
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/azure
> Affects Versions: 3.4.1
> Reporter: Anmol Asrani
> Assignee: Manika Joshi
> Priority: Major
> Labels: pull-request-available
>
> In ABFS Driver, user delegation SAS is currently only supported by
> hierarchical namespace (HNS) enabled accounts (over DFS endpoint). This PR
> adds support for User Delegation SAS for non-HNS accounts over Blob endpoint
> as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
