manika137 commented on code in PR #7523:
URL: https://github.com/apache/hadoop/pull/7523#discussion_r2050042305
##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/utils/DelegationSASGenerator.java:
##########
@@ -68,18 +70,25 @@ public String getDelegationSAS(String accountName, String
containerName, String
case SASTokenProvider.DELETE_RECURSIVE_OPERATION:
sp = "d";
sr = "d";
- sdd = Integer.toString(StringUtils.countMatches(path, "/"));
+ sdd = path.equals("/")? "0":
Integer.toString(StringUtils.countMatches(path, "/"));
Review Comment:
Converted it to path.equals(ROOT_PATH)? "0":
Integer.toString(StringUtils.countMatches(path, "/"));
Did not change the last "/" part for readability purpose
##########
hadoop-tools/hadoop-azure/src/site/markdown/index.md:
##########
@@ -651,13 +651,16 @@ To know more about how SAS Authentication works refer to
[Grant limited access to Azure Storage resources using shared access
signatures
(SAS)](https://learn.microsoft.com/en-us/azure/storage/common/storage-sas-overview)
There are three types of SAS supported by Azure Storage:
-- [User Delegation
SAS](https://learn.microsoft.com/en-us/rest/api/storageservices/create-user-delegation-sas):
Recommended for use with ABFS Driver with HNS Enabled ADLS Gen2 accounts. It
is Identity based SAS that works at blob/directory level)
+- [User Delegation
SAS](https://learn.microsoft.com/en-us/rest/api/storageservices/create-user-delegation-sas):
+ Recommended for use with ABFS Driver with HNS Enabled ADLS Gen2 accounts. It
+ is Identity based SAS that works at blob/directory level)
- [Service
SAS](https://learn.microsoft.com/en-us/rest/api/storageservices/create-service-sas):
Global and works at container level.
- [Account
SAS](https://learn.microsoft.com/en-us/rest/api/storageservices/create-account-sas):
Global and works at account level.
#### Known Issues With SAS
Review Comment:
Taken
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
