[
https://issues.apache.org/jira/browse/HADOOP-19433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948313#comment-17948313
]
ASF GitHub Bot commented on HADOOP-19433:
-----------------------------------------
slfan1989 commented on code in PR #7586:
URL: https://github.com/apache/hadoop/pull/7586#discussion_r2067625209
##########
hadoop-tools/hadoop-extras/src/test/java/org/apache/hadoop/mapred/tools/TestGetGroups.java:
##########
@@ -52,4 +53,33 @@ protected Tool getTool(PrintStream o) {
return new GetGroups(conf, o);
}
+ @Test
Review Comment:
@jojochuang Thank you for your suggestion. In my opinion, there's no need
to override. Your suggestion is good, and we can remove this class.
> Upgrade JUnit from 4 to 5 in hadoop-extras.
> -------------------------------------------
>
> Key: HADOOP-19433
> URL: https://issues.apache.org/jira/browse/HADOOP-19433
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: build, test
> Affects Versions: 3.5.0
> Reporter: Shilun Fan
> Assignee: Shilun Fan
> Priority: Major
> Labels: pull-request-available
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
