[
https://issues.apache.org/jira/browse/HADOOP-19562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17950680#comment-17950680
]
ASF GitHub Bot commented on HADOOP-19562:
-----------------------------------------
GauthamBanasandra opened a new pull request, #7679:
URL: https://github.com/apache/hadoop/pull/7679
<!--
Thanks for sending a pull request!
1. If this is your first time, please read our contributor guidelines:
https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
2. Make sure your PR title starts with JIRA issue id, e.g.,
'HADOOP-17799. Your PR title ...'.
-->
### Description of PR
The following 2 tests are failing in TestTextCommand -
1. testDisplayForNonWritableSequenceFile
2. testDisplayForSequenceFileSmallMultiByteReads
These tests create a file and flush a string ending with "\n". However, for
verification, the test expects "\r\n" as the line ending on Windows. Thus, the
test fails.
This PR fixes the same by checking for "\n" as the line ending on Windows.
### How was this patch tested?
1. Ran the fixed unit tests locally.
2. Jenkins CI validation.
### For code changes:
- [x] Does the title or this PR starts with the corresponding JIRA issue id
(e.g. 'HADOOP-17799. Your PR title ...')?
- [ ] Object storage: have the integration tests been executed and the
endpoint declared according to the connector-specific documentation?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`,
`NOTICE-binary` files?
> Fix TestTextCommand on Windows
> ------------------------------
>
> Key: HADOOP-19562
> URL: https://issues.apache.org/jira/browse/HADOOP-19562
> Project: Hadoop Common
> Issue Type: Bug
> Components: hadoop-common, test
> Affects Versions: 3.5.0
> Environment: Windows 10
> Reporter: Gautham Banasandra
> Assignee: Gautham Banasandra
> Priority: Major
> Fix For: 3.5.0
>
>
> The following 2 tests are failing in TestTextCommand -
> 1. testDisplayForNonWritableSequenceFile
> 2. testDisplayForSequenceFileSmallMultiByteReads
> These tests create a file and flush a string ending with "\n". However, for
> verification, the test expects "\r\n" as the line ending on Windows. Thus,
> the test fails.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
