slfan1989 commented on code in PR #7419:
URL: https://github.com/apache/hadoop/pull/7419#discussion_r2083686539
##########
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/localfs/TestLocalFSContractLoaded.java:
##########
@@ -38,16 +38,16 @@ protected AbstractFSContract createContract(Configuration
conf) {
@Test
public void testContractWorks() throws Throwable {
String key = getContract().getConfKey(SUPPORTS_ATOMIC_RENAME);
- assertNotNull("not set: " + key, getContract().getConf().get(key));
- assertTrue("not true: " + key,
- getContract().isSupported(SUPPORTS_ATOMIC_RENAME, false));
+ assertNotNull(getContract().getConf().get(key), "not set: " + key);
+ assertTrue(getContract().isSupported(SUPPORTS_ATOMIC_RENAME, false),
+ "not true: " + key);
}
@Test
public void testContractResourceOnClasspath() throws Throwable {
URL url = this.getClass()
.getClassLoader()
.getResource(LocalFSContract.CONTRACT_XML);
- assertNotNull("could not find contract resource", url);
+ assertNotNull(url, "could not find contract resource");
}
}
Review Comment:
I will improve this part of the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
