steveloughran commented on PR #7699: URL: https://github.com/apache/hadoop/pull/7699#issuecomment-2895627960
me having set a per-bucket override for fs.s3a.buffer.dir meant that the fallback to hadoop.tmp.dir never got tested. but, because of how dir allocators were in a static conf -> instance mapping, this only surfaced depending on what the config in earlier runs was. the stuff with the space is so that you can explicitly set a value for the fs.s3a.bucket.BUCKET.buffer.dir and so not have the per-bucket mapping code pick up the one in the auth-keys.xml config instead. And it looks like a space is needed for that mapping, rather than "". But that's OK as if you look at the local dir allocator code it does `StringUtils.getTrimmedStrings` on the conf value, so we should fall back to hadoop.tmp.dir if the buffer dir is a space. Too me a while to work out WTF was wrong. I was worried the local dir allocator patch had actually triggered a regression -but really it was me changing my test setup surfaced a latent bug. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
