[
https://issues.apache.org/jira/browse/HADOOP-19394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17955003#comment-17955003
]
ASF GitHub Bot commented on HADOOP-19394:
-----------------------------------------
ahmarsuhail commented on code in PR #7720:
URL: https://github.com/apache/hadoop/pull/7720#discussion_r2114283705
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/streams/AnalyticsStream.java:
##########
@@ -128,6 +139,33 @@ public int read(byte[] buf, int off, int len) throws
IOException {
return bytesRead;
}
+ /**
+ * {@inheritDoc}
+ * Pass to {@link #readVectored(List, IntFunction, Consumer)}
+ * with the {@link VectoredReadUtils#LOG_BYTE_BUFFER_RELEASED} releaser.
+ * @param ranges the byte ranges to read.
+ * @param allocate the function to allocate ByteBuffer.
+ * @throws IOException IOE if any.
+ */
+ @Override
+ public synchronized void readVectored(List<? extends FileRange> ranges,
Review Comment:
sorry my miss.. we just discussed, this does not need to be synchronized.
will cut
> S3A Analytics Accelerator: vector IO support
> --------------------------------------------
>
> Key: HADOOP-19394
> URL: https://issues.apache.org/jira/browse/HADOOP-19394
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 3.4.1
> Reporter: Steve Loughran
> Priority: Major
> Labels: pull-request-available
>
> Add vector IO support for analytics accelerator stream
> Three stages
> # pull up s3a input stream to work with all ObjectInputStreams; do its own
> fetching independent of the analytics stream
> # provide info to stream of fetches having taken place (remove from cache,
> cancel prefetch)
> full integration
> * return a range from cache if present
> * append to the block retrieval callback if a prefetch is in progress
> * only do merge + new request if the range cannot be satisifed entirely from
> cached data
> Out of scope: handling case where part of a range is in cache/retrieval. Too
> complicated and so prone to problems.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
