[ 
https://issues.apache.org/jira/browse/HADOOP-8422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13281644#comment-13281644
 ] 

Daryn Sharp commented on HADOOP-8422:
-------------------------------------

bq.  Got a nit though: The calls "get*Default*Replication", etc. have 'default' 
in them and sorta make no sense given a path object, given also that they're 
non-static methods within a FileSystem API? Shouldn't they be simply 
getReplication, etc.? If you agree, I'll file another JIRA.

I kind of see what you are saying, but it actually does make sense given a 
{{Path}} object.  The question it's answering is: "what are the default values 
for the actual filesystem that will contain this given path?".

I confused by the concern with the methods being non-static.  A fs, such as 
{{ViewFileSystem}} must be able to override the method to resolve the path 
through the mount table to get the real fs.  Maybe we are talking past each 
other, so what methods & signatures are you envisioning?
                
> FileSystem#getDefaultBlockSize and Replication don't use the given path
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-8422
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8422
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>    Affects Versions: 1.0.3
>            Reporter: Eli Collins
>            Priority: Minor
>
> The javadocs for FileSystem#getDefaultBlockSize and 
> FileSystem#getDefaultReplication claim that "The given path will be used to 
> locate the actual filesystem" however they both ignore the path.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to