bhattmanish98 commented on code in PR #7713: URL: https://github.com/apache/hadoop/pull/7713#discussion_r2125698814
########## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClient.java: ########## @@ -152,6 +153,7 @@ public abstract class AbfsClient implements Closeable { public static final Logger LOG = LoggerFactory.getLogger(AbfsClient.class); public static final String HUNDRED_CONTINUE_USER_AGENT = SINGLE_WHITE_SPACE + HUNDRED_CONTINUE + SEMICOLON; public static final String ABFS_CLIENT_TIMER_THREAD_NAME = "abfs-timer-client"; + public static final String FNS_BLOB_USER_AGENT_IDENTIFIER = "FNS"; Review Comment: Any reason for just facing FNS as value for FNS Blob user agent? FNS user agent can be there for FNS DFS as well, right? ########## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/ITestAbfsClient.java: ########## @@ -355,6 +356,44 @@ public void verifyUserAgentClusterType() throws Exception { .contains(DEFAULT_VALUE_UNKNOWN); } + @Test + // Test to verify the unique identifier in user agent string for FNS-Blob accounts + public void verifyUserAgentForFNSBlob() throws Exception { + Assume.assumeTrue(JDK_HTTP_URL_CONNECTION == httpOperationType); Review Comment: Why this assume for connection type? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org