slfan1989 commented on code in PR #7739:
URL: https://github.com/apache/hadoop/pull/7739#discussion_r2157778332
##########
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSUtil.java:
##########
@@ -219,16 +218,18 @@ public void getSecondaryNameServiceId() {
* exception is thrown when multiple rpc addresses match the local node's
* address
*/
- @Test(expected = HadoopIllegalArgumentException.class)
+ @Test
public void testGetNameServiceIdException() {
- HdfsConfiguration conf = new HdfsConfiguration();
- conf.set(DFS_NAMESERVICES, "nn1,nn2");
- conf.set(DFSUtil.addKeySuffixes(DFS_NAMENODE_RPC_ADDRESS_KEY, "nn1"),
- "localhost:9000");
- conf.set(DFSUtil.addKeySuffixes(DFS_NAMENODE_RPC_ADDRESS_KEY, "nn2"),
- "localhost:9001");
- DFSUtil.getNamenodeNameServiceId(conf);
- fail("Expected exception is not thrown");
+ Assertions.assertThrows(HadoopIllegalArgumentException.class, () -> {
Review Comment:
avoid `Assertions.assertThrows`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
