[ https://issues.apache.org/jira/browse/HADOOP-8415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13282153#comment-13282153 ]
Harsh J commented on HADOOP-8415: --------------------------------- This is good enough - just one nit: There are currently no tests that do setDouble() as well (the current test appends strings to baseconf), can you add a couple of ones for those too? Would be good to have that coverage. Other than that +1, pending jenkins-run after new patch. > getDouble() and setDouble() in org.apache.hadoop.conf.Configuration > ------------------------------------------------------------------- > > Key: HADOOP-8415 > URL: https://issues.apache.org/jira/browse/HADOOP-8415 > Project: Hadoop Common > Issue Type: Improvement > Components: conf > Affects Versions: 1.0.2 > Reporter: Jan van der Lugt > Priority: Minor > Attachments: HADOOP-8415.patch > > Original Estimate: 0.25h > Remaining Estimate: 0.25h > > In the org.apache.hadoop.conf.Configuration class, methods exist to set > Integers, Longs, Booleans, Floats and Strings, but methods for Doubles are > absent. Are they not there for a reason or should they be added? In the > latter case, the attached patch contains the missing functions. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira