ahmarsuhail commented on code in PR #7763: URL: https://github.com/apache/hadoop/pull/7763#discussion_r2166549299
########## hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3AAnalyticsAcceleratorStreamReading.java: ########## @@ -23,8 +23,8 @@ import java.io.IOException; import java.io.InputStream; Review Comment: what other test cases can you think of that can make these GET assertions useful? For example, if we read an object of size ~10MB, can we assert that we made only 2 GETs? Similarly if read a small object, can we assert there was only a single GET? If we passed in the object lenght when opening the object, can we assert that there were 0 HEADs? If there are concurrent streams reading the same object, can we assert that there are no duplicate GETs? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
