LuciferYang commented on code in PR #7759: URL: https://github.com/apache/hadoop/pull/7759#discussion_r2163240121
########## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/SignalUtil.java: ########## @@ -0,0 +1,152 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.util; + +import org.apache.hadoop.classification.InterfaceAudience; + +import org.apache.hadoop.util.dynamic.BindingUtils; +import org.apache.hadoop.util.dynamic.DynConstructors; +import org.apache.hadoop.util.dynamic.DynMethods; + +import java.lang.reflect.InvocationHandler; +import java.lang.reflect.Proxy; + +@InterfaceAudience.Private +public class SignalUtil { + + static final Class<?> jdkSignalClazz = + BindingUtils.loadClassSafely("sun.misc.Signal"); + static final Class<?> jdkSignalHandlerClazz = + BindingUtils.loadClassSafely("sun.misc.SignalHandler"); + + static DynConstructors.Ctor<?> jdkSignalCtor = + new DynConstructors.Builder() + .impl(jdkSignalClazz, String.class) + .build(); + + static DynMethods.StaticMethod jdkSignalHandleStaticMethod = + new DynMethods.Builder("handle") + .impl(jdkSignalClazz, jdkSignalClazz, jdkSignalHandlerClazz) + .buildStatic(); + + static DynMethods.StaticMethod jdkSignalRaiseStaticMethod = + new DynMethods.Builder("raise") + .impl(jdkSignalClazz, jdkSignalClazz) + .buildStatic(); + + static DynMethods.UnboundMethod jdkSignalHandlerHandleMethod = + new DynMethods.Builder("handle") + .impl(jdkSignalHandlerClazz, jdkSignalClazz) + .build(); + + @InterfaceAudience.Private + public static class Signal { + private final static DynMethods.UnboundMethod getNumberMethod = + new DynMethods.Builder("getNumber").impl(jdkSignalClazz).build(); + + private final static DynMethods.UnboundMethod getNameMethod = + new DynMethods.Builder("getName").impl(jdkSignalClazz).build(); + + private final Object delegate; + + public Signal(String name) { + this.delegate = jdkSignalCtor.newInstance(name); + } + + public Signal(Object delegate) { + Preconditions.checkArgument(jdkSignalClazz.isInstance(delegate), + String.format("Expected class is '%s', but actual class is '%s'", + jdkSignalClazz.getName(), delegate.getClass().getName())); + this.delegate = delegate; + } + + public int getNumber() { + return getNumberMethod.bind(delegate).invoke(); Review Comment: It seems that the `delegate` and `Signal` instances are bound together. Can the redundant `bind` calls be omitted here? ########## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/SignalUtil.java: ########## @@ -0,0 +1,152 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.util; + +import org.apache.hadoop.classification.InterfaceAudience; + +import org.apache.hadoop.util.dynamic.BindingUtils; +import org.apache.hadoop.util.dynamic.DynConstructors; +import org.apache.hadoop.util.dynamic.DynMethods; + +import java.lang.reflect.InvocationHandler; +import java.lang.reflect.Proxy; + +@InterfaceAudience.Private +public class SignalUtil { + + static final Class<?> jdkSignalClazz = + BindingUtils.loadClassSafely("sun.misc.Signal"); + static final Class<?> jdkSignalHandlerClazz = + BindingUtils.loadClassSafely("sun.misc.SignalHandler"); + + static DynConstructors.Ctor<?> jdkSignalCtor = + new DynConstructors.Builder() + .impl(jdkSignalClazz, String.class) + .build(); + + static DynMethods.StaticMethod jdkSignalHandleStaticMethod = + new DynMethods.Builder("handle") + .impl(jdkSignalClazz, jdkSignalClazz, jdkSignalHandlerClazz) + .buildStatic(); + + static DynMethods.StaticMethod jdkSignalRaiseStaticMethod = + new DynMethods.Builder("raise") + .impl(jdkSignalClazz, jdkSignalClazz) + .buildStatic(); + + static DynMethods.UnboundMethod jdkSignalHandlerHandleMethod = + new DynMethods.Builder("handle") + .impl(jdkSignalHandlerClazz, jdkSignalClazz) + .build(); + + @InterfaceAudience.Private + public static class Signal { + private final static DynMethods.UnboundMethod getNumberMethod = + new DynMethods.Builder("getNumber").impl(jdkSignalClazz).build(); + + private final static DynMethods.UnboundMethod getNameMethod = + new DynMethods.Builder("getName").impl(jdkSignalClazz).build(); + + private final Object delegate; + + public Signal(String name) { + this.delegate = jdkSignalCtor.newInstance(name); + } + + public Signal(Object delegate) { + Preconditions.checkArgument(jdkSignalClazz.isInstance(delegate), + String.format("Expected class is '%s', but actual class is '%s'", + jdkSignalClazz.getName(), delegate.getClass().getName())); + this.delegate = delegate; + } + + public int getNumber() { + return getNumberMethod.bind(delegate).invoke(); + } + + public String getName() { + return getNameMethod.bind(delegate).invoke(); Review Comment: ditto -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
