slfan1989 commented on code in PR #7653: URL: https://github.com/apache/hadoop/pull/7653#discussion_r2173586020
########## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/integration/AzureTestConstants.java: ########## @@ -141,7 +141,7 @@ public interface AzureTestConstants { */ int SCALE_TEST_TIMEOUT_SECONDS = 30 * 60; - int SCALE_TEST_TIMEOUT_MILLIS = SCALE_TEST_TIMEOUT_SECONDS * 1000; + int SCALE_TEST_TIMEOUT_MILLIS = SCALE_TEST_TIMEOUT_SECONDS; Review Comment: Thank you very much for your suggestion! I have thought of a solution that has less impact on the code: when introducing Timeout, we can explicitly specify the time unit, so we won't need to modify the variable anymore. ``` Timeout(value = AzureTestConstants.AZURE_TEST_TIMEOUT, unit = TimeUnit.MILLISECONDS) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org