anujmodi2021 commented on code in PR #7765:
URL: https://github.com/apache/hadoop/pull/7765#discussion_r2174789793
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AbfsConfiguration.java:
##########
@@ -1525,8 +1529,8 @@ void setMaxBackoffIntervalMilliseconds(int
maxBackoffInterval) {
}
@VisibleForTesting
- void setIsNamespaceEnabledAccount(String isNamespaceEnabledAccount) {
- this.isNamespaceEnabledAccount = isNamespaceEnabledAccount;
+ public void setIsNamespaceEnabledAccount(Trilean isNamespaceEnabledAccount) {
Review Comment:
We should be setting this value on abfsconfiguration object only when we
know the exact value. Do we really need this to be Trilean? I think we should
pass the definitive argument and do the Boolean to Trilean conversion here just
to make sure that no one accidently sets UNKNOWN here.
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystemStore.java:
##########
@@ -443,7 +428,7 @@ private synchronized boolean
getNamespaceEnabledInformationFromServer(
*/
@VisibleForTesting
boolean isNamespaceEnabled() throws TrileanConversionException {
- return this.isNamespaceEnabled.toBoolean();
+ return abfsConfiguration.getIsNamespaceEnabledAccount().toBoolean();
Review Comment:
Better to use getter here and other places for abfsconfiguration. This will
make sure same object is being referred everywhere and can easily be mocked if
needed in future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
