slfan1989 commented on code in PR #7757: URL: https://github.com/apache/hadoop/pull/7757#discussion_r2179392761
########## hadoop-tools/hadoop-azure-datalake/src/test/java/org/apache/hadoop/fs/adl/live/TestAdlPermissionLive.java: ########## @@ -71,22 +73,23 @@ public static Collection adlCreateNonRecursiveTestData() return datas; } - @AfterClass + @AfterAll public static void cleanUp() throws IOException, URISyntaxException { if (AdlStorageConfiguration.isContractTestEnabled()) { - Assert.assertTrue(AdlStorageConfiguration.createStorageConnector() + assertTrue(AdlStorageConfiguration.createStorageConnector() .delete(testRoot, true)); } } - @Before Review Comment: @anujmodi2021 Thank you for your question! ParameterizedTest in JUnit 5 is a special type of unit test. Unlike JUnit 4, ParameterizedTest requires the initialization of certain parameters directly in the test method, so the setup function is executed at that point. If we add `@BeforeEach`, the variables in `setup` would not be initialized yet. Therefore, we don't need to add `@BeforeEach`; instead, we should call `setup` within `initTestAdlPermissionLive`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org