[
https://issues.apache.org/jira/browse/HADOOP-19595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18003716#comment-18003716
]
ASF GitHub Bot commented on HADOOP-19595:
-----------------------------------------
bhattmanish98 commented on code in PR #7765:
URL: https://github.com/apache/hadoop/pull/7765#discussion_r2192005567
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClient.java:
##########
@@ -1322,8 +1323,9 @@ String initializeUserAgent(final AbfsConfiguration
abfsConfiguration,
sb.append(abfsConfiguration.getClusterType());
// Add a unique identifier in FNS-Blob user agent string
- if (!getIsNamespaceEnabled()
- && abfsConfiguration.getFsConfiguredServiceType() == BLOB) {
+ // Current filesystem init restricts HNS-Blob combination
+ // so namespace check not required.
+ if (BLOB == abfsConfiguration.getFsConfiguredServiceType()) {
Review Comment:
Currently, we only support FNS over Blob endpoint. HNS-Blob will fail during
init only.
After having offline discussion with the team, I made this change.
> ABFS: AbfsConfiguration should store account type information (HNS or FNS)
> --------------------------------------------------------------------------
>
> Key: HADOOP-19595
> URL: https://issues.apache.org/jira/browse/HADOOP-19595
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/azure
> Affects Versions: 3.4.1
> Reporter: Manish Bhatt
> Assignee: Manish Bhatt
> Priority: Major
> Labels: pull-request-available
>
> Currently, both {{AbfsClient}} and {{AzureBlobFileSystemStore}} store
> information about whether the account is FNS or HNS (i.e., whether namespace
> is enabled). This information should instead be stored at the
> {{AbfsConfiguration}} level, allowing both the client and the store to
> retrieve it from there when needed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
