[
https://issues.apache.org/jira/browse/HADOOP-19425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18005059#comment-18005059
]
ASF GitHub Bot commented on HADOOP-19425:
-----------------------------------------
anujmodi2021 commented on code in PR #7674:
URL: https://github.com/apache/hadoop/pull/7674#discussion_r2203849749
##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/AbstractAbfsScaleTest.java:
##########
@@ -18,18 +18,23 @@
package org.apache.hadoop.fs.azurebfs;
+import org.junit.jupiter.api.Timeout;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.apache.hadoop.conf.Configuration;
import org.apache.hadoop.fs.azure.integration.AzureTestConstants;
+import java.util.concurrent.TimeUnit;
+
+import static
org.apache.hadoop.fs.azure.integration.AzureTestConstants.SCALE_TEST_TIMEOUT_MILLIS;
import static
org.apache.hadoop.fs.azure.integration.AzureTestUtils.assumeScaleTestsEnabled;
/**
* Integration tests at bigger scale; configurable as to
* size, off by default.
*/
+@Timeout(value = SCALE_TEST_TIMEOUT_MILLIS, unit = TimeUnit.MILLISECONDS)
Review Comment:
Is it newly getting introduced?
##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/AbstractAbfsScaleTest.java:
##########
@@ -18,18 +18,23 @@
package org.apache.hadoop.fs.azurebfs;
+import org.junit.jupiter.api.Timeout;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.apache.hadoop.conf.Configuration;
import org.apache.hadoop.fs.azure.integration.AzureTestConstants;
+import java.util.concurrent.TimeUnit;
+
+import static
org.apache.hadoop.fs.azure.integration.AzureTestConstants.SCALE_TEST_TIMEOUT_MILLIS;
import static
org.apache.hadoop.fs.azure.integration.AzureTestUtils.assumeScaleTestsEnabled;
/**
* Integration tests at bigger scale; configurable as to
* size, off by default.
*/
+@Timeout(value = SCALE_TEST_TIMEOUT_MILLIS, unit = TimeUnit.MILLISECONDS)
public class AbstractAbfsScaleTest extends AbstractAbfsIntegrationTest {
Review Comment:
setup method of this class should also be annotated with @BeforeEach.
This is causing some test failures.
##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsCustomEncryption.java:
##########
@@ -178,14 +170,35 @@ public static Iterable<Object[]> params() {
});
}
- public ITestAbfsCustomEncryption() throws Exception {
+ public void initITestAbfsCustomEncryption(EncryptionType pFileEncryptionType,
Review Comment:
This seems like too much work around in Junit5.
I saw a discussion that we are planning to simplify this with an updated
version of Junit5. Should we try to add some TODOs so that we know where all we
need to simplify Parameterised tests so that we don't skip any?
##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/extensions/ITestAbfsDelegationTokens.java:
##########
@@ -74,7 +74,7 @@ public class ITestAbfsDelegationTokens extends
AbstractAbfsIntegrationTest {
/***
* Set up the clusters.
*/
- @BeforeClass
+ @BeforeAll
Review Comment:
setup() and teardown() in this class also need to be annotated
##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsListStatusRemoteIterator.java:
##########
@@ -44,10 +41,14 @@
import org.apache.hadoop.fs.azurebfs.utils.TracingContext;
import org.apache.hadoop.test.LambdaTestUtils;
+import static org.assertj.core.api.Assertions.assertThat;
import static org.mockito.ArgumentMatchers.any;
-import static org.mockito.ArgumentMatchers.anyBoolean;
-import static org.mockito.ArgumentMatchers.anyList;
import static org.mockito.ArgumentMatchers.nullable;
+import static org.mockito.Mockito.anyBoolean;
Review Comment:
Is this change also part of this upgrade?
> [ABFS] Upgrade JUnit from 4 to 5 in hadoop-azure.
> -------------------------------------------------
>
> Key: HADOOP-19425
> URL: https://issues.apache.org/jira/browse/HADOOP-19425
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: build, fs/azure, test
> Affects Versions: 3.5.0
> Reporter: Shilun Fan
> Assignee: Shilun Fan
> Priority: Major
> Labels: pull-request-available
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
