[
https://issues.apache.org/jira/browse/HADOOP-19627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18008059#comment-18008059
]
ASF GitHub Bot commented on HADOOP-19627:
-----------------------------------------
ahmarsuhail opened a new pull request, #7816:
URL: https://github.com/apache/hadoop/pull/7816
<!--
Thanks for sending a pull request!
1. If this is your first time, please read our contributor guidelines:
https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
2. Make sure your PR title starts with JIRA issue id, e.g.,
'HADOOP-17799. Your PR title ...'.
-->
### Description of PR
We were previously creating second file with the same object content, so the
etag will always be the same, leading to test failures, except when testing
with an encryption method set, as in that case eTag is no longer the md5.
### How was this patch tested?
Can't test on trunk as the all tests in this class fail due to the Junit5
migration. Will test on 3.4.
> testIfMatchOverwriteWithOutdatedEtag() fails when not using SSE-KMS
> -------------------------------------------------------------------
>
> Key: HADOOP-19627
> URL: https://issues.apache.org/jira/browse/HADOOP-19627
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 3.5.0, 3.4.2
> Reporter: Ahmar Suhail
> Priority: Major
>
> ITestS3APutIfMatchAndIfNoneMatch.testIfMatchOverwriteWithOutdatedEtag() fails
> when no encryption method is set.
>
> This is because it does
> createFileWithFlags(fs, path, SMALL_FILE_BYTES, true, null);
>
> and then to overwrite the file, also does
>
> createFileWithFlags(fs, path, SMALL_FILE_BYTES, true, null);
>
> When no encryption is used, the eTAG is the md5 of the object, and so will
> always be the same, and won't result in the 412 conditional write failure.
>
> Test passes when using SSE-KMS, as when using encryption, eTag is no longer
> the md5 of the object content, and changes on every write.
>
>
> Fix is simple enough, change the object content on the second write.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
