steveloughran commented on code in PR #7707:
URL: https://github.com/apache/hadoop/pull/7707#discussion_r2219761321
##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemMainOperation.java:
##########
@@ -50,16 +50,6 @@ public void setUp() throws Exception {
fSys = binding.getFileSystem();
}
- @AfterEach
- @Override
Review Comment:
again, cut. even if it isn't needed
##########
hadoop-cloud-storage-project/hadoop-huaweicloud/pom.xml:
##########
@@ -94,6 +94,23 @@
</plugin>
</plugins>
</build>
+ <dependencyManagement>
+ <dependencies>
+ <!-- due to a dependency convergence error caused by esdk-obs-java -->
+ <dependency>
Review Comment:
declare these in hadoop-project pom.xml and then reference here; this helps
unify version declarations and simplifies finding where artifacts are used.
##########
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3AFSMainOperations.java:
##########
@@ -55,13 +55,6 @@ protected FileSystem createFileSystem() throws Exception {
return contract.getTestFileSystem();
}
- @Override
Review Comment:
can you leave this out. we are still stabilising junit 5 testing for ABFS
and S3A, and it's going to interfere. I look at what needs to be done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
