[
https://issues.apache.org/jira/browse/HADOOP-19636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18009461#comment-18009461
]
ASF GitHub Bot commented on HADOOP-19636:
-----------------------------------------
slfan1989 commented on code in PR #7822:
URL: https://github.com/apache/hadoop/pull/7822#discussion_r2227448044
##########
dev-support/docker/Dockerfile_centos_8:
##########
@@ -1,118 +0,0 @@
-# Licensed to the Apache Software Foundation (ASF) under one
-# or more contributor license agreements. See the NOTICE file
-# distributed with this work for additional information
-# regarding copyright ownership. The ASF licenses this file
-# to you under the Apache License, Version 2.0 (the
-# "License"); you may not use this file except in compliance
-# with the License. You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-
-# Dockerfile for installing the necessary dependencies for building Hadoop.
-# See BUILDING.txt.
-
-FROM centos:8
Review Comment:
The choice of operating system should be made by the user, and therefore,
the resolution of compilation issues should also be handled by the user.
Take CentOS 7 as an example, which has multiple versions (such as 7.2, 7.3,
7.9, etc.). Different versions may have configuration or dependency differences
(e.g., glibc, gcc versions), which can lead to compilation issues, such as with
protobuf or native package compilation. For these issues, we should not add
extra workarounds, as that would make the project redundant.
If we were to upgrade to `CentOS 9`, we would change the Dockerfile name
from `Dockerfile_centos_8` to `Dockerfile_centos_9`. Users comparing the diff
would see that `Dockerfile_centos_8` has been deleted and replaced with
`Dockerfile_centos_9`, which contains entirely new content.
> [JDK17] Remove EOL OS Support and Clean Up Dockerfile.
> ------------------------------------------------------
>
> Key: HADOOP-19636
> URL: https://issues.apache.org/jira/browse/HADOOP-19636
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Shilun Fan
> Assignee: Shilun Fan
> Priority: Major
> Labels: pull-request-available
>
> Removed build support for the following EOL (End-of-Life) operating system
> versions (e.g., CentOS 7, Debian 9, etc.).
> Cleaned up redundant code and dependency configurations in the Dockerfile
> related to these operating systems.
> Optimized the build logic to ensure that currently supported OS versions
> build successfully.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
