slfan1989 commented on PR #7868: URL: https://github.com/apache/hadoop/pull/7868#issuecomment-3190296832
@anujmodi2021 Thank you for your contribution! I noticed a small improvement we could make in this PR: removing the junit-vintage-engine dependency. This dependency is used for running mixed JUnit 4 and JUnit 5 tests, but since this module has been fully migrated to JUnit 5, I believe we can safely remove it. https://github.com/apache/hadoop/blob/1abdf72dca0c530c265859362b2a2d574d8c9d72/hadoop-tools/hadoop-azure/pom.xml#L363-L367 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org