[
https://issues.apache.org/jira/browse/HADOOP-8469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13288639#comment-13288639
]
Robert Joseph Evans commented on HADOOP-8469:
---------------------------------------------
Junping Du,
I have been looking at some of your patches, but there is a lot here to go
through and it is likely to take some time. The first thing I would like to
see happen though is to have a Rollup Jira filed to track the entire change
that you are trying to make. It looks like you are trying to add in
"NodeGroup" support across all of Hadoop. Within that ticket it would really
be nice if you could explain what you are trying to do, and why you are trying
to do it. What benefit is this large set of changes going to give the
community. If you have a design document that would be good if not just a
quick overview of the changes being made. This is mostly so I, and other
community members can grok the big picture of what you are trying to do here,
so we can evaluate it at a high level, before getting into the line by line
changes that you are making.
The second thing I would like to see happen is to have you move your JIRAs to
the appropriate project. HDFS JIRAs should be moved out of HADOOP and into
HDFS, Mapreduce should go to MAPREDUCE, and only the ones that stay in HADOOP
should be for code that goes under the hadoop-common-project directory.
The third thing I would like to see is to then have you link up all of the
JIRAs so that we can see which JIRAs have dependencies on which other ones.
This includes linking up all of your JIRAs to the Rollup JIRA so the entire
change can be tracked.
Be aware that this large of a set of changes is going to take a while for us to
go through.
Thanks
> Make NetworkTopology class pluggable and support user specified topology class
> ------------------------------------------------------------------------------
>
> Key: HADOOP-8469
> URL: https://issues.apache.org/jira/browse/HADOOP-8469
> Project: Hadoop Common
> Issue Type: Sub-task
> Affects Versions: 1.0.0, 2.0.0-alpha
> Reporter: Junping Du
> Assignee: Junping Du
> Attachments: HADOOP-8469-NetworkTopology-pluggable-v2.patch,
> HADOOP-8469-NetworkTopology-pluggable.patch
>
>
> The class NetworkTopology is where the three-layer hierarchical topology is
> modeled in the current code base and is instantiated directly by the
> DatanodeManager and Balancer.
> To support alternative topologies, changes were make the topology class
> pluggable, that is to support using a user specified topology class specified
> in the Hadoop configuration file core-defaul.xml. The user specified topology
> class is instantiated using reflection in the same manner as other
> customizable classes in Hadoop. If no use specified topology class is found,
> the fallback is to use the NetworkTopology to preserve current behavior. To
> make it possible to reuse code in NetworkTopology several minor changes were
> made to make the class more extensible. The NetworkTopology class is
> currently annotated with @InterfaceAudience.LimitedPrivate({"HDFS",
> "MapReduce"}) and @InterfaceStability.Unstable.
> The proposed changes in NetworkTopology listed below
> 1. Some fields were changes from private to protected
> 2. Added some protected methods so that sub classes could override behavior
> 3. Added a new method,isNodeGroupAware,to NetworkTopology
> 4. The inner class InnerNode was made a package protected class to it would
> be easier to subclass
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira