[
https://issues.apache.org/jira/browse/HADOOP-19364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18028750#comment-18028750
]
ASF GitHub Bot commented on HADOOP-19364:
-----------------------------------------
ahmarsuhail commented on PR #8007:
URL: https://github.com/apache/hadoop/pull/8007#issuecomment-3385655172
@steveloughran this PR address some of your comments on the original IoStats
PR.
The way the AAL code works currently means it's quite hard to report on a
cache hit accurately, so I've skipped that for now. It's something we should
report, but will need a bit of a rewrite on our end. I'll see how we can do
that.
Also quite hard to report on durations (I couldn't think of a way, but it
would be nice to do that). We'll need someway so that when the GET request
starts, it creates a duration tracker, and then when it finishes, that tracker
is closed. but since these callbacks are implemented at a stream level, it
doesn't seem possible to track durations for each individual request. any
suggestions?
Other than that this PR is now ready for another review.
> S3A Analytics-Accelerator: Add IoStatistics support
> ---------------------------------------------------
>
> Key: HADOOP-19364
> URL: https://issues.apache.org/jira/browse/HADOOP-19364
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Reporter: Ahmar Suhail
> Priority: Major
> Labels: pull-request-available
>
> S3A provides InputStream statistics:
> [https://github.com/apache/hadoop/blob/trunk/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/statistics/S3AInputStreamStatistics.java]
> This helps track things like how many bytes were read from a stream etc.
>
> The current integration does not currently implement statistics. To start off
> with we should identify which of these statistics makes sense for us track in
> the new stream. Some examples are:
>
> 1/ bytesRead
> 2/ readOperationStarted
> 3/ initiateGetRequest
>
> Some of these (1 and 2) are more straightforward, and should not require any
> changes to analytics-accelerator-s3, but tracking GET requests will require
> this.
> We should also add tests that make assertions on these statistics. See
> ITestS3APrefetchingInputStream for an example to do this.
> And see https://issues.apache.org/jira/browse/HADOOP-18190 for how this was
> done on the prefetching stream, and PR:
> https://github.com/apache/hadoop/pull/4458
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
