[ 
https://issues.apache.org/jira/browse/HADOOP-8486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13290368#comment-13290368
 ] 

Bikas Saha commented on HADOOP-8486:
------------------------------------

If I understand this right, Hive tries to create this object to validate file 
format and the creation fails often enough for a lot of tests to fail because 
of this issue. Isn't there a better way to validate the file format.

Back to this, are you sure about calling close() on a partially constructed 
object?

You are checking for in!=null but there is no explicit initialization of in to 
null to inform programmers about this dependency. Java default initializes in 
to null and so this works.
                
> Resource leak - Close the open resource handles (File handles) before 
> throwing the exception from the SequenceFile constructor
> ------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-8486
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8486
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs, io
>    Affects Versions: 1.0.2
>            Reporter: Kanna Karanam
>         Attachments: HADOOP-8486-branch-1-win.patch
>
>
> I noticed this problem while I am working on porting HIVE to work on windows. 
> Hive is attempting to create this class object to validate the file format 
> and end up with resource leak. Because of this leak, we can’t move, rename or 
> delete the files on windows when there is an open file handle whereas in UNIX 
> we can perform all these operation with no issues even with open file handles.
> Please suggest me if you similar issues in any other places.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to