[ https://issues.apache.org/jira/browse/HADOOP-8470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13292195#comment-13292195 ]
Hadoop QA commented on HADOOP-8470: ----------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12531498/HADOOP-8470-NetworkTopology-new-impl-v3.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.fs.viewfs.TestViewFsTrash +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1104//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1104//console This message is automatically generated. > Implementation of 4-layer subclass of NetworkTopology > (NetworkTopologyWithNodeGroup) > ------------------------------------------------------------------------------------ > > Key: HADOOP-8470 > URL: https://issues.apache.org/jira/browse/HADOOP-8470 > Project: Hadoop Common > Issue Type: Sub-task > Affects Versions: 1.0.0, 2.0.0-alpha > Reporter: Junping Du > Assignee: Junping Du > Attachments: HADOOP-8470-NetworkTopology-new-impl-v2.patch, > HADOOP-8470-NetworkTopology-new-impl-v3.patch, > HADOOP-8470-NetworkTopology-new-impl.patch > > > To support the four-layer hierarchical topology shown in attached figure as a > subclass of NetworkTopology, NetworkTopologyWithNodeGroup was developed along > with unit tests. NetworkTopologyWithNodeGroup overriding the methods add, > remove, and pseudoSortByDistance were the most relevant to support the > four-layer topology. The method seudoSortByDistance selects the nodes to use > for reading data and sorts the nodes in sequence of node-local, > nodegroup-local, rack- local, rack–off. Another slightly change to > seudoSortByDistance is to support cases of separation data node and node > manager: if the reader cannot be found in NetworkTopology tree (formed by > data nodes only), then it will try to sort according to reader's sibling node > in the tree. > The distance calculation changes the weights from 0 (local), 2 (rack- local), > 4 (rack-off) to: 0 (local), 2 (nodegroup-local), 4 (rack-local), 6 (rack-off). > The additional node group layer should be specified in the topology script or > table mapping, e.g. input 10.1.1.1, output: /rack1/nodegroup1 > A subclass on InnerNode, InnerNodeWithNodeGroup, was also needed to support > NetworkTopologyWithNodeGroup. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira